jvrao commented on a change in pull request #1532: ISSUE #1527: Make
ExplicitLAC persistent
URL: https://github.com/apache/bookkeeper/pull/1532#discussion_r201737053
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
##########
@@ -206,9 +218,11 @@ public synchronized void readHeader() throws IOException {
throw new IOException("Missing ledger signature while reading
header for " + lf);
}
int version = bb.getInt();
- if (version != HEADER_VERSION) {
+ if (version > CURRENT_HEADER_VERSION) {
throw new IOException("Incompatible ledger version " + version
+ " while reading header for " + lf);
Review comment:
So this prevents software rollback period. isn't it? Should we consider
coming up ? what are the downsides of that? yeah we may not read the
explicitLAC other than that, is there anything else? I am worried if there are
any situations where we make the cluster not usable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
