eolivelli commented on a change in pull request #1577: Metadata Update mechanism
URL: https://github.com/apache/bookkeeper/pull/1577#discussion_r207357350
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
##########
@@ -185,7 +226,7 @@ private LedgerMetadata() {
return ensembles;
}
- void setEnsembles(TreeMap<Long, ? extends List<BookieSocketAddress>>
newEnsembles) {
+ void setEnsembles(Map<Long, ? extends List<BookieSocketAddress>>
newEnsembles) {
this.ensembles = newEnsembles.entrySet().stream()
.collect(TreeMap::new,
(m, e) -> m.put(e.getKey(),
ImmutableList.copyOf(e.getValue())),
Review comment:
Collections.unmodifiableList ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
