sijie commented on a change in pull request #1582: Enhancing
DecommissionBookieCmd
URL: https://github.com/apache/bookkeeper/pull/1582#discussion_r208013531
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
##########
@@ -2529,14 +2529,16 @@ public int runCmd(CommandLine cmdLine) throws
Exception {
.isBlank(remoteBookieidToDecommission) ?
Bookie.getBookieAddress(bkConf)
: new
BookieSocketAddress(remoteBookieidToDecommission));
admin.decommissionBookie(bookieAddressToDecommission);
- LOG.info("The ledgers stored in the given decommissioning
bookie are properly replicated");
+ LOG.info("The ledgers stored in the given decommissioning
bookie: {} are properly replicated",
+ bookieAddressToDecommission);
runFunctionWithRegistrationManager(bkConf, rm -> {
try {
Versioned<Cookie> cookie =
Cookie.readFromRegistrationManager(rm, bookieAddressToDecommission);
cookie.getValue().deleteFromRegistrationManager(rm,
bookieAddressToDecommission,
cookie.getVersion());
} catch (CookieNotFoundException nne) {
- LOG.warn("No cookie to remove, it could be deleted
already : ", nne);
+ LOG.warn("No cookie to remove for the decommissioning
bookie: " + bookieAddressToDecommission
Review comment:
https://www.slf4j.org/api/src-html/org/slf4j/Logger.html#line.509 doesn't
this work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
