ivankelly commented on a change in pull request #1589: Make LedgerHandle 
injectable
URL: https://github.com/apache/bookkeeper/pull/1589#discussion_r209220875
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
 ##########
 @@ -536,52 +484,33 @@ public BookKeeper(ClientConfiguration conf, ZooKeeper 
zk, EventLoopGroup eventLo
         }
         this.ledgerManager = new 
CleanupLedgerManager(ledgerManagerFactory.newLedgerManager());
         this.ledgerIdGenerator = ledgerManagerFactory.newLedgerIdGenerator();
-        this.explicitLacInterval = conf.getExplictLacInterval();
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("Explicit LAC Interval : {}", this.explicitLacInterval);
-        }
 
-        this.addEntryQuorumTimeoutNanos = 
TimeUnit.SECONDS.toNanos(conf.getAddEntryQuorumTimeout());
-        scheduleBookieHealthCheckIfEnabled();
+        scheduleBookieHealthCheckIfEnabled(conf);
     }
 
     /**
      * Allow to extend BookKeeper for mocking in unit tests.
      */
     @VisibleForTesting
     BookKeeper() {
+        conf = new ClientConfiguration();
+        internalConf = ClientInternalConf.defaultValues();
         statsLogger = NullStatsLogger.INSTANCE;
+        clientStats = BookKeeperClientStats.newInstance(statsLogger);
         scheduler = null;
         requestTimer = null;
-        reorderReadSequence = false;
         metadataDriver = null;
-        readSpeculativeRequestPolicy = Optional.absent();
 
 Review comment:
   this is only used in one test, and I've rejigged that test to pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to