ivankelly commented on a change in pull request #1599: Fix master versions 
(4.8.0-SNAPSHOT->4.9.0-SNAPSHOT)
URL: https://github.com/apache/bookkeeper/pull/1599#discussion_r209422672
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -699,15 +699,10 @@
               <artifactId>checkstyle</artifactId>
               <version>${puppycrawl.checkstyle.version}</version>
             </dependency>
-            <dependency>
-              <groupId>org.apache.bookkeeper</groupId>
-              <artifactId>buildtools</artifactId>
-              <version>${project.version}</version>
-            </dependency>
           </dependencies>
           <configuration>
-            <configLocation>bookkeeper/checkstyle.xml</configLocation>
-            
<suppressionsLocation>bookkeeper/suppressions.xml</suppressionsLocation>
+            
<configLocation>buildtools/src/main/resources/bookkeeper/checkstyle.xml</configLocation>
 
 Review comment:
   The checkstyle plugin has a dependency on 
org.apache.bookeeper:buildtools:${version}. If you bump the version and run 
checkstyle without running mvn install first, like we do in CI, CI will fail 
because it can't find the dependency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to