sijie commented on a change in pull request #1599: Fix master versions 
(4.8.0-SNAPSHOT->4.9.0-SNAPSHOT)
URL: https://github.com/apache/bookkeeper/pull/1599#discussion_r209432036
 
 

 ##########
 File path: tests/scripts/src/test/bash/bk_test_bin_common.sh
 ##########
 @@ -32,7 +32,8 @@ testDefaultVariables() {
   assertEquals "BINDIR is not set correctly" "${BK_BINDIR}" "${BINDIR}"
   assertEquals "BK_HOME is not set correctly" "${BK_HOMEDIR}" "${BK_HOME}"
   assertEquals "DEFAULT_LOG_CONF is not set correctly" 
"${BK_CONFDIR}/log4j.properties" "${DEFAULT_LOG_CONF}"
-  assertEquals "NETTY_LEAK_DETECTION_LEVEL is not set correctly" "disabled" 
"${NETTY_LEAK_DETECTION_LEVEL}"
+  assertEquals "NETTY_LEAK_DETECTION_LEVEL is not set correctly" "disabled" 
"${NETTY_LEAK
 
 Review comment:
   do you mind reverting this change back? because the change will become 
misleading. in future if similar problem happens, people might check the gitlog 
and follow what the change was doing here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to