eolivelli commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r218301605
########## File path: circe-checksum/src/main/java/com/scurrilous/circe/utils/NativeUtils.java ########## @@ -67,13 +67,16 @@ public static void loadLibraryFromJar(String path) throws Exception { throw new FileNotFoundException("Couldn't find file into jar " + path); } - OutputStream out = new FileOutputStream(temp); try { - while ((read = input.read(buffer)) != -1) { - out.write(buffer, 0, read); + OutputStream out = new FileOutputStream(temp); Review comment: Try-with-resources ? Or IoUtils or java.nio.files.Files ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services