kishorekasi commented on a change in pull request #1678: Issue ##1333: TLS
handshake failure on certificate expiry
URL: https://github.com/apache/bookkeeper/pull/1678#discussion_r219290760
##########
File path: bookkeeper-server/pom.xml
##########
@@ -263,31 +290,6 @@
</dependency>
</dependencies>
</profile>
- <profile>
- <id>tls-certs</id>
- <build>
Review comment:
Yes. Previously I created a long lived self signed certificate which lacked
host name verification. With the current changes, certificate verification
requires the host ip and hostname to be part of the certificate. So, each host
building/running tests would need to generate host specific self signed
certificates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
