sijie commented on a change in pull request #1693:
autorecovery-use-metadata-driver (part 1) : move AutoRecoveryMain to use
MetadataBookieDriver
URL: https://github.com/apache/bookkeeper/pull/1693#discussion_r219539734
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
##########
@@ -85,40 +85,36 @@ public AutoRecoveryMain(ServerConfiguration conf,
StatsLogger statsLogger)
throws IOException, InterruptedException, KeeperException,
UnavailableException,
CompatibilityException {
this.conf = conf;
- Set<Watcher> watchers = new HashSet<Watcher>();
- // TODO: better session handling for auto recovery daemon
https://issues.apache.org/jira/browse/BOOKKEEPER-594
Review comment:
yeah, it doesn't really make sense to shutdown auto recovery when expired
from zookeeper, especially if the underlying zookeeper is reconnectable. I am
not worried about replication worker and the normal zookeeper metadata
operations in auditor, however can you explain a bit after removing this part,
how does Auditor elector handles the expire and retries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
