reddycharan commented on a change in pull request #1683: Enhance Auditor
URL: https://github.com/apache/bookkeeper/pull/1683#discussion_r219636963
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -661,6 +693,11 @@ void checkAllLedgers() throws BKException, IOException,
InterruptedException, Ke
}
}, null, BKException.Code.OK, BKException.Code.ReadException);
FutureUtils.result(processFuture, BKException.HANDLER);
+ try {
+
ledgerUnderreplicationManager.setCheckAllLedgersCTime(System.currentTimeMillis());
+ } catch (UnavailableException ue) {
+ LOG.error("Got exception while trying to set
checkAllLedgersCTime", ue);
Review comment:
didn't get you completely. Also not sure how cache would work in all the
scenarios here.
Anyhow frequency of checkAllLedgers is quite low (once a week), I don't see
much value in this minor optimization and not sure if it is worth complicating
logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
