eolivelli commented on a change in pull request #1678: Issue ##1333: TLS
handshake failure on certificate expiry
URL: https://github.com/apache/bookkeeper/pull/1678#discussion_r219664645
##########
File path: bookkeeper-server/pom.xml
##########
@@ -263,31 +290,6 @@
</dependency>
</dependencies>
</profile>
- <profile>
- <id>tls-certs</id>
- <build>
Review comment:
I prefer to create certs only when needed, with this setup every time you
launch any single test from the command line you will create new certificates,
it slows down every day work, for tests and code which is not changed very
frequently
Cc @ivankelly @sijie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
