codingwangqi commented on a change in pull request #1693:
autorecovery-use-metadata-driver (part 1) : move AutoRecoveryMain to use
MetadataBookieDriver
URL: https://github.com/apache/bookkeeper/pull/1693#discussion_r219715587
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
##########
@@ -85,40 +85,36 @@ public AutoRecoveryMain(ServerConfiguration conf,
StatsLogger statsLogger)
throws IOException, InterruptedException, KeeperException,
UnavailableException,
CompatibilityException {
this.conf = conf;
- Set<Watcher> watchers = new HashSet<Watcher>();
- // TODO: better session handling for auto recovery daemon
https://issues.apache.org/jira/browse/BOOKKEEPER-594
Review comment:
There is a logic in AuditorElector will shutdown itself when session expired
:
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java#L203
when AuditorElector shuts itself down, the death watcher will quit and then
AutoRecoveryMain will quit. so the session expire logic in AutoRecoveryMain is
not really needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
