sijie closed pull request #1692: Enable
storeSystemTimeAsLedgerUnderreplicatedMarkTime
URL: https://github.com/apache/bookkeeper/pull/1692
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
index 666b377b30..a3c47abda7 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
@@ -851,7 +851,7 @@ public T
setStoreSystemTimeAsLedgerUnderreplicatedMarkTime(boolean enabled) {
* underreplicated ledger mark time.
*/
public boolean getStoreSystemTimeAsLedgerUnderreplicatedMarkTime() {
- return
getBoolean(STORE_SYSTEMTIME_AS_LEDGER_UNDERREPLICATED_MARK_TIME, false);
+ return
getBoolean(STORE_SYSTEMTIME_AS_LEDGER_UNDERREPLICATED_MARK_TIME, true);
}
/**
diff --git a/conf/bk_server.conf b/conf/bk_server.conf
index 93c12a142c..97404fb1bb 100755
--- a/conf/bk_server.conf
+++ b/conf/bk_server.conf
@@ -911,7 +911,7 @@ zkEnableSecurity=false
# Enable the Auditor to use system time as underreplicated ledger mark time.
# If this is enabled, Auditor will write a ctime field into the
underreplicated ledger znode.
-# storeSystemTimeAsLedgerUnderreplicatedMarkTime=false
+# storeSystemTimeAsLedgerUnderreplicatedMarkTime=true
#############################################################################
## Replication Worker settings
diff --git a/site/_data/config/bk_server.yaml b/site/_data/config/bk_server.yaml
index 991d6f1fce..b60bfbf993 100644
--- a/site/_data/config/bk_server.yaml
+++ b/site/_data/config/bk_server.yaml
@@ -648,6 +648,7 @@ groups:
default: 0
- param: storeSystemTimeAsLedgerUnderreplicatedMarkTime
description: Enable the Auditor to use system time as underreplicated
ledger mark time. If this is enabled, Auditor will write a ctime field into the
underreplicated ledger znode.
+ default: true
- name: AutoRecovery replication worker settings
params:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
