sijie commented on a change in pull request #1678: Issue ##1333: TLS handshake
failure on certificate expiry
URL: https://github.com/apache/bookkeeper/pull/1678#discussion_r220290271
##########
File path: bookkeeper-server/pom.xml
##########
@@ -263,31 +290,6 @@
</dependency>
</dependencies>
</profile>
- <profile>
- <id>tls-certs</id>
- <build>
Review comment:
an alternative is to move tls related stuff to its module, so the certs
generation can only happen in that module. but that's probably in a separate PR.
@eolivelli if not regenerate certs, how are you going to test certificate
verification as what @kishorekasi suggested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
