codingwangqi commented on a change in pull request #1695:
autorecovery-use-metadata-driver (part 3) : remove zookeeper from Auditor class
URL: https://github.com/apache/bookkeeper/pull/1695#discussion_r220294825
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -104,8 +102,50 @@
private Set<String> bookiesToBeAudited = Sets.newHashSet();
private volatile int lostBookieRecoveryDelayBeforeChange;
- public Auditor(final String bookieIdentifier, ServerConfiguration conf,
- ZooKeeper zkc, StatsLogger statsLogger) throws
UnavailableException {
+ static BookKeeper createBookKeeperClient(ServerConfiguration conf)
+ throws InterruptedException, IOException {
+ ClientConfiguration clientConfiguration = new
ClientConfiguration(conf);
+
clientConfiguration.setClientRole(ClientConfiguration.CLIENT_ROLE_SYSTEM);
+ LOG.info("AuthProvider used by the Auditor is {}",
Review comment:
nice catch. I addressed your comment in the latest change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
