eolivelli commented on a change in pull request #1678: Issue ##1333: TLS
handshake failure on certificate expiry
URL: https://github.com/apache/bookkeeper/pull/1678#discussion_r220301591
##########
File path: bookkeeper-server/pom.xml
##########
@@ -263,31 +290,6 @@
</dependency>
</dependencies>
</profile>
- <profile>
- <id>tls-certs</id>
- <build>
Review comment:
@sijie my suggestion it to generate certificates only when running tests
which need the certificates, otherwise you will end generating certs at every
mvn test -Dtest=xxxx
We can do it in a @beforeclass or another approach is to add some logic in
the bash script so that if the cert is already present it won't be regenerated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
