jiazhai commented on a change in pull request #1722: [table service][client]
Provide a simple version of storage clients
URL: https://github.com/apache/bookkeeper/pull/1722#discussion_r221611333
##########
File path:
stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java
##########
@@ -249,6 +253,10 @@ public static LifecycleComponent
buildStorageServer(CompositeConfiguration conf,
dlConf,
rootStatsLogger.scope("dlog"));
+ // client settings for the proxy channels
+ StorageClientSettings proxyClientSettings =
StorageClientSettings.newBuilder()
+ .serviceUri("bk://localhost:" + grpcPort)
Review comment:
seems this changes brings in #1721 , this PR is related with
7e1439aea1d77f524abf197ea3852cb9cdde0d03
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
