sijie commented on a change in pull request #1721: [table service][storage] add
routing table for proxying table service requests
URL: https://github.com/apache/bookkeeper/pull/1721#discussion_r221650574
##########
File path:
stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java
##########
@@ -249,6 +253,10 @@ public static LifecycleComponent
buildStorageServer(CompositeConfiguration conf,
dlConf,
rootStatsLogger.scope("dlog"));
+ // client settings for the proxy channels
+ StorageClientSettings proxyClientSettings =
StorageClientSettings.newBuilder()
+ .serviceUri("bk://localhost:" + grpcPort)
Review comment:
it should be working as fine.
alternatively we can use grpc InprocessChannel. I didn't go to that route,
because I think loopback is probably much reliable than using InprocessChannel.
since using InprocessChannel we have to consider the sequence on constructing
service and the client, which can be tricky. So I would prefer using loopback
as for now, and change it if it turns out to be a bottleneck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
