eolivelli commented on a change in pull request #1727: [table services][perf] Provides a simple perf tool for testing put and inc performance URL: https://github.com/apache/bookkeeper/pull/1727#discussion_r221921243
########## File path: stream/statelib/src/main/java/org/apache/bookkeeper/statelib/impl/kv/RocksdbKVStore.java ########## @@ -275,7 +275,7 @@ protected void openRocksdb(StateStoreSpec spec) throws StateStoreException { // initialize the write options writeOpts = new WriteOptions(); - writeOpts.setDisableWAL(false); // disable wal, since the source of truth will be on distributedlog + writeOpts.setDisableWAL(true); // disable wal, since the source of truth will be on distributedlog Review comment: Add a comment in order to explain this. I guess I know the reason but better to be clear ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services