codingwangqi commented on a change in pull request #1701:
autorecovery-use-metadata-driver (part 4) : provide an `AuditorSelector`
interface to abstract leader election logic for AuditorElector
URL: https://github.com/apache/bookkeeper/pull/1701#discussion_r222534734
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java
##########
@@ -250,16 +252,26 @@ public synchronized LedgerManagerFactory
getLedgerManagerFactory()
return lmFactory;
}
- @Override
- public void close() {
- if (null != lmFactory) {
+ public AuditorSelector getAuditorSelector(String bookieId) {
+ return new ZkAuditorSelector(bookieId, zk, new
ServerConfiguration(conf));
+ }
+
+ protected synchronized void closeLedgerManagerFactory() {
Review comment:
you are right. we do not need synchronized here. removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
