reddycharan commented on a change in pull request #1735: Issue 1703:
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222750446
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
##########
@@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity,
int readCapacity, long
@Override
public synchronized void close() throws IOException {
+ if (closed) {
Review comment:
hmm..not sure why it is needed. Following calls are supposed to be
idempotent right?
```
ReferenceCountUtil.safeRelease(writeBuffer);
fileChannel.close();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
