sijie commented on a change in pull request #1735: Issue 1703:
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222770031
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
##########
@@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity,
int readCapacity, long
@Override
public synchronized void close() throws IOException {
+ if (closed) {
Review comment:
it can probably double closed because the way we managed `try() finally {}`
at shutting down entry log manager. we can fix the logic there. however I don't
think that is a redirection to go, because if close() is being called twice in
different places, the problem still exists. so I went down to this path to make
close idempotent in the base class, which it will address the problem of now
and any potentially problems in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
