eolivelli commented on a change in pull request #1747: Set ConnectionExpired 
Listener to MetadataClientDriver in AR
URL: https://github.com/apache/bookkeeper/pull/1747#discussion_r223946133
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataClientDriver.java
 ##########
 @@ -84,4 +84,23 @@ LedgerManagerFactory getLedgerManagerFactory()
     @Override
     void close();
 
+    /**
+     * Listener on listening the metadata client connection expiry event.
+     */
+    @FunctionalInterface
+    interface ConnectionExpiredListener {
+
+        /**
+         * Signal when connection is expired.
+         */
+        void onConnectionExpired();
 
 Review comment:
   I would call this simply 'onFatalError' or something that is simply telling 
that service should suicide.
   
   Session expiration, and maybe session, is a ZK concept.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to