ivankelly commented on a change in pull request #1755: Configure Netty
allocator in bookie and client
URL: https://github.com/apache/bookkeeper/pull/1755#discussion_r228460816
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/checksum/CRC32CDigestManager.java
##########
@@ -38,10 +39,10 @@ protected MutableInt initialValue() throws Exception {
}
};
- public CRC32CDigestManager(long ledgerId, boolean useV2Protocol) {
- super(ledgerId, useV2Protocol);
+ public CRC32CDigestManager(long ledgerId, boolean useV2Protocol,
ByteBufAllocator allocator) {
+ super(ledgerId, useV2Protocol, allocator);
if (!Sse42Crc32C.isSupported()) {
- log.error("Sse42Crc32C is not supported, will use less slower
CRC32C implementation.");
+ log.error("Sse42Crc32C is not supported, will use slower CRC32C
implementation.");
Review comment:
If you're correcting the grammar, you should at least include the indefinite
article ;)
Let's see if this suggestion thing works...
```suggestion
log.error("Sse42Crc32C is not supported, will use a slower
CRC32C implementation.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
