merlimat commented on a change in pull request #1755: Configure Netty
allocator in bookie and client
URL: https://github.com/apache/bookkeeper/pull/1755#discussion_r228686668
##########
File path: bookkeeper-server/pom.xml
##########
@@ -37,6 +37,18 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.bookkeeper</groupId>
+ <artifactId>bookkeeper-common-allocator</artifactId>
+ <version>${project.parent.version}</version>
+ <exclusions>
+ <!-- exclude "netty-buffer" since "netty-all" already introduces it -->
Review comment:
Good point, will fix that. In general we should also refactor netty
dependency to not use netty-all, but that's a completely different story
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
