dlg99 commented on issue #1782: Issue #1781: Add traces/zipkin support to simplify troubleshooting of slow requests URL: https://github.com/apache/bookkeeper/pull/1782#issuecomment-435534926 @merlimat I agree with this concern. NOOP tracer should not create an overhead (it does not create span/context objects and uses same noop instance as far as I can tell, it does not set active trace as thread local etc.) If actual tracer is used but sample is set to 0 we'll end up with traces created but not reported (unless somewhere along the way app created active trace that had "sample flag" set. There are some places where tags are set and i.e. string concatenation is used to build the tag. I'll move these out to make sure string concatenation does not happen if tracing is a NOOP. Otherwise tags on noop spans/context do nothing. @sijie Let me make sure that I understood you correctly. Pretty much we need better way to specify tracer, so something similar to metrics in BK where one can drop in a jar and specify class name to use. API along the lines of createTracer, contextToByteString, byteStringToContext. I agree, I'll do that. I short-circuited this part to get review out sooner. Opentracing stays as the tracing API. I treat it same way as we do slf4j for logging. I figured since other apache projects use it directly we can do too, i.e. https://github.com/apache/hadoop/compare/trunk...carlosalberto:ot_initial_integration#diff-1f7d0efa26604bfd48d1754534a77becR262 Users can implement their version of Tracer (i.e. opencensus) and register it as GlobalTracer. i.e. in current implementation any application that uses bk client will have to register tracer on its own, it does not happen as part of client creation/builder.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
