sijie commented on a change in pull request #1755: Configure Netty allocator
in bookie and client
URL: https://github.com/apache/bookkeeper/pull/1755#discussion_r231604653
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
##########
@@ -124,6 +124,7 @@ public BookieServer(ServerConfiguration conf, StatsLogger
statsLogger)
*/
public void setExceptionHandler(UncaughtExceptionHandler exceptionHandler)
{
this.uncaughtExceptionHandler = exceptionHandler;
+ this.bookie.setExceptionHandler(exceptionHandler);
Review comment:
nit: since bookie is not final, there can be possibility `bookie` is null if
these methods are not called in correct order. can we add `final` modifier to
`bookie` field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
