eolivelli commented on a change in pull request #1682: Added BlockingQueue
implementation based on JCtools
URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232078181
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
##########
@@ -116,7 +117,7 @@ ByteBuf getExplicitLac() {
* @param journal log the fence entry in the Journal
* @return A future which will be satisfied when add entry to journal
complete
*/
- private SettableFuture<Boolean> logFenceEntryInJournal(Journal journal) {
+ private SettableFuture<Boolean> logFenceEntryInJournal(Journal journal)
throws InterruptedException {
Review comment:
This method returns a Future, I wonder if it is okay to throw the
Interrupted Exception or to return a failed Future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
