sijie closed pull request #1804: [client] read submission for readonly handle
should bypass OSE threads.
URL: https://github.com/apache/bookkeeper/pull/1804
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
index 12e00e84fb..e559821559 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
@@ -471,7 +471,12 @@ public synchronized boolean isClosed() {
return getLedgerMetadata().isClosed();
}
- boolean isHandleWritable() {
+ /**
+ * Return if this handle is writable or not.
+ *
+ * @return true if this handle is writable, otherwise false
+ */
+ protected boolean isHandleWritable() {
return !getLedgerMetadata().isClosed() && handleState ==
HandleState.OPEN;
}
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
index e4794de575..a2359d5d19 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
@@ -108,6 +108,11 @@ public String toString() {
}
}
+ @Override
+ protected boolean isHandleWritable() {
+ return false;
+ }
+
@Override
public void close()
throws InterruptedException, BKException {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
