sijie commented on a change in pull request #1807: [bookie] Fix sorted ledger
storage rotating entry log files too frequent
URL: https://github.com/apache/bookkeeper/pull/1807#discussion_r232935167
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
##########
@@ -98,11 +98,32 @@ public void initialize(ServerConfiguration conf,
Checkpointer checkpointer,
StatsLogger statsLogger)
throws IOException {
+ initializeWithEntryLogListener(
+ conf,
+ ledgerManager,
+ ledgerDirsManager,
+ indexDirsManager,
+ stateManager,
+ checkpointSource,
+ checkpointer,
+ this,
+ statsLogger);
+ }
+
+ void initializeWithEntryLogListener(ServerConfiguration conf,
Review comment:
Actually I think currently entry log listener is only visible to interleaved
and sorte ledger storages. but it is not visible to db ledger storage. so I
think it is probably better to use my approach here, since the behavior is only
applied to interleaved and sorted ledger storage.
we can improve it later if this listener is going to be applied to all
ledger storage implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
