reddycharan commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent URL: https://github.com/apache/bookkeeper/pull/1807#discussion_r233123238
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForEntryLogPerLedger.java ########## @@ -640,7 +640,9 @@ BufferedLogChannel getCurrentLogForLedgerForAddEntry(long ledgerId, int entrySiz if (logChannel != null) { logChannel.flushAndForceWriteIfRegularFlush(false); } - createNewLog(ledgerId); + createNewLog(ledgerId, + ": diskFull = " + diskFull + ", allDisksFull = " + allDisksFull + + ", reachEntryLogLimit = " + reachEntryLogLimit); Review comment: we can get to this block even if logChannel is null. so add that aswell to the reason string. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services