sijie commented on a change in pull request #1809: Change LedgerManager to use
CompletableFuture
URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233123746
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
##########
@@ -144,7 +143,7 @@ public void run() {
}
}
} else {
- LOG.warn("Failed on read ledger metadata of ledger {} : {}",
ledgerId, rc);
+ LOG.warn("Failed on read ledger metadata of ledger {}",
ledgerId, exception);
Review comment:
I don't think the exception stack trace is useful here (in async callbacks).
so I think we should still use `rc` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
