eolivelli commented on a change in pull request #1802: [branch 4.8] Fix
compilation issue introduced by issue #1791
URL: https://github.com/apache/bookkeeper/pull/1802#discussion_r233211173
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -494,6 +494,10 @@ public synchronized boolean isClosed() {
return getLedgerMetadata().isClosed();
}
+ boolean isHandleWritable() {
+ return !getLedgerMetadata().isClosed();
Review comment:
@jvrao that was my concern as well, but it turned out that changing this
method to return false for ReadOnlyLeadgerHandle would break many recovery tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
