athanatos commented on a change in pull request #1819: ISSUE-1770: Add local
checker for Sorted/InterleavedLedgerStorage
URL: https://github.com/apache/bookkeeper/pull/1819#discussion_r239953007
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -863,6 +919,25 @@ public synchronized void start() {
LOG.error("Error on executing a fully flush after replaying
journals.");
shutdown(ExitCode.BOOKIE_EXCEPTION);
}
+
+ if (conf.isLocalConsistencyCheckOnStartup()) {
+ LOG.info("Running local consistency check on startup prior to
accepting IO.");
+ List<LedgerStorage.DetectedInconsistency> errors = null;
+ try {
+ errors = ledgerStorage.localConsistencyCheck(Optional.empty());
+ } catch (IOException e) {
+ LOG.error("Got a fatal exception while checking store", e);
+ shutdown(ExitCode.BOOKIE_EXCEPTION);
+ }
+ if (errors != null && errors.size() > 0) {
+ LOG.error("Bookie failed local consistency check:");
+ for (LedgerStorage.DetectedInconsistency error : errors) {
+ LOG.error("Ledger {}, entry {}: ", error.getLedgerId(),
error.getEntryId(), error.getException());
+ }
+ shutdown(ExitCode.BOOKIE_EXCEPTION);
Review comment:
Yep, fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
