eolivelli commented on a change in pull request #1864:  HTTP GetMetaService 
returns JSON rather than calling #serialize
URL: https://github.com/apache/bookkeeper/pull/1864#discussion_r248657968
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
 ##########
 @@ -132,7 +132,7 @@ public void initiate() {
             metadataBuilder.withCustomMetadata(customMetadata);
         }
         if (bk.getConf().getStoreSystemtimeAsLedgerCreationTime()) {
-            metadataBuilder.withCreationTime(System.currentTimeMillis());
+            
metadataBuilder.withCreationTime(System.currentTimeMillis()).storingCreationTime(true);
 
 Review comment:
   This sounds like an unrelated bug.
   Okay for keeping.
   I wonder why we did not catch this bug on tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to