eolivelli commented on a change in pull request #1902: (WIP) Metadata checker
validating EnsemblePlacementpolicy
URL: https://github.com/apache/bookkeeper/pull/1902#discussion_r248783101
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -743,11 +825,11 @@ public void operationComplete(int rc,
Set<LedgerFragment> fragments) {
* be run very often.
*/
void checkAllLedgers() throws BKException, IOException,
InterruptedException, KeeperException {
- final BookKeeper client = createBookKeeperClient(conf);
- final BookKeeperAdmin admin = new BookKeeperAdmin(client, statsLogger);
+ final BookKeeper localClient = createBookKeeperClient(conf);
Review comment:
Better to use try-with-resources otherwise you could fail to close the
client if the admin close fails
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
