ivankelly opened a new pull request #1916: Add semantically meaningful return values to placement policy URL: https://github.com/apache/bookkeeper/pull/1916 Currently newEnsemble and replaceBookie in EnsemblePlacementPolicy return a apache commons Pair<> with the second argument being a boolean to denote whether the placement conforms strictly to the policy. From calling code, the meaning of this second value is unclear. This patch replaces Pair<> with an PlacementResult object, in which the strict conformity argument is clearly labels. This will also allow extension in the future to return more metadata about particular placements. Also, we shouldn't put third party library classes in interfaces. Issue: #1914
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
