eolivelli commented on a change in pull request #1917: Ignore usage of 
localNode in PlacementPolicy.
URL: https://github.com/apache/bookkeeper/pull/1917#discussion_r251129250
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java
 ##########
 @@ -56,18 +56,20 @@ protected RackawareEnsemblePlacementPolicy 
initialize(DNSToSwitchMapping dnsReso
                                                           int 
maxWeightMultiple,
                                                           int 
minNumRacksPerWriteQuorum,
                                                           boolean 
enforceMinNumRacksPerWriteQuorum,
+                                                          boolean 
ignoreLocalNodeInPlacementPolicy,
 
 Review comment:
   In the near future we should refactor this method and introduce a single 
bean or anyhow reduce the number of parameters.
   Not blocker for this change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to