eolivelli commented on a change in pull request #1931: (WIP)
GetListOfEntriesOfLedger implementation
URL: https://github.com/apache/bookkeeper/pull/1931#discussion_r253198678
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
##########
@@ -335,4 +335,10 @@ public boolean isInForceGC() {
return ledgerStorageList.stream()
.map(single ->
single.getGarbageCollectionStatus().get(0)).collect(Collectors.toList());
}
+
+ @Override
+ public byte[] getEntriesOfLedger(long ledgerId) {
+ // TODO Auto-generated method stub
+ return null;
Review comment:
not sure how can we deal with this
I guess we have to implement this one as well, or have some kind of protocol
in which the bookie can report to the client something like 'I don't know which
are the entries I have'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
