rdhabalia commented on a change in pull request #1937: [bk-gc] Fix GC thread
gets blocked
URL: https://github.com/apache/bookkeeper/pull/1937#discussion_r254832540
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java
##########
@@ -240,7 +241,12 @@ public void operationComplete(int rc, List<String>
ledgers) {
synchronized (ctx) {
while (!ctx.done) {
- ctx.wait();
+ try {
+ ctx.wait(timeOutSec > 0 ?
TimeUnit.SECONDS.toMillis(timeOutSec) : 0);
Review comment:
it throws IOException that will be caught at the very top and gc
metadata-iteration fails. so, current gc task fails and next gc task will again
run to continue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
