karanmehta93 commented on a change in pull request #2090: Update and flush
lastLogMark when replaying journal
URL: https://github.com/apache/bookkeeper/pull/2090#discussion_r282572119
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -196,11 +196,11 @@ void rollLog(LastLogMark lastMark) throws
NoWritableLedgerDirException {
// which is safe since records before lastMark have been
// persisted to disk (both index & entry logger)
lastMark.getCurMark().writeLogMark(bb);
- if (LOG.isDebugEnabled()) {
- LOG.debug("RollLog to persist last marked log : {}",
lastMark.getCurMark());
- }
+
+ LOG.info("RollLog to persist last marked log : {}",
lastMark.getCurMark());
Review comment:
@reddycharan
I switched this log line from `DEBUG` to `INFO` since I believe that this is
an important event to be logged. However given that we use ELPL, which flushes
every 10 seconds, is this a problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
