reddycharan commented on a change in pull request #2090: Update and flush
lastLogMark when replaying journal
URL: https://github.com/apache/bookkeeper/pull/2090#discussion_r282599781
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
##########
@@ -640,6 +637,15 @@ public void testTruncatedInEntryJournal() throws
Exception {
}
}
+ private Bookie startBookieReadJournal(ServerConfiguration conf) throws
IOException, InterruptedException, BookieException {
Review comment:
nit: technically you are not starting Bookie (not calling start method of
Bookie), so better rename it to createBookieAndReadJournal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
