karanmehta93 opened a new pull request #2094: (WIP) Have min time interval for force compaction URL: https://github.com/apache/bookkeeper/pull/2094 Descriptions of the changes in this PR: Work continued from https://github.com/apache/bookkeeper/pull/1946 Descriptions of the changes in this PR (WIP): - Added support for scheduling tasks with fixed delay in `MockExecutorController` - Can be used for adding unit tests for GC threads, LedgerDirsMonitor threads etc - Fixed some broken tests - Re-based the PR Descriptions of the changes in PR 1946: - minimum interval needed to trigger force compaction by LedgerDirsListener, since the last main compaction. Otherwise if isForceGCAllowWhenNoSpace is enabled and when disk reaches storage threshold, it will do busy force gc for every 'diskCheckInterval' (10 secs) untill the disk/bookie becomes writable again. gc operation is an expensive operation and it puts load on metadataserver for iterating over all ledgers metadata. So we should call forcegc judiciously when disk/bookie reaches storage threshold. - here main compaction will be Major compaction, if majorcompaction is disabled/suspended then it will be minorcompaction. If both major and minor are disabled/suspended then it will be just gc run. - in LedgerDirsMonitor and in GarbageCollectorThread we should schedule tasks with fixed delay instead of at fixed rate. This would ensure that there would be uniform delay between executions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
