ankit-j commented on a change in pull request #2096: Entries must be
acknowledged by bookies in multiple fault domains before being acknowledged to
client
URL: https://github.com/apache/bookkeeper/pull/2096#discussion_r286271132
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTest.java
##########
@@ -956,4 +958,121 @@ public void testLedgerDeletionIdempotency() throws
Exception {
bk.deleteLedger(ledgerId);
bk.close();
}
+
+ /**
+ * Mock of RackawareEnsemblePlacementPolicy. Overrides
areAckedBookiesAdheringToPlacementPolicy to only return true
+ * when ackedBookies consists of 3 bookies. Also adds a counter to track
the number of invocations of
+ * areAckedBookiesAdheringToPlacementPolicy and getter/setter for that.
+ */
+ public static class MockRackawareEnsemblePlacementPolicy extends
RackawareEnsemblePlacementPolicy {
+ private AtomicInteger counter = new AtomicInteger(0);
+ private int writeQuorumSizeToUseForTesting = 3;
Review comment:
Doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
