codelipenghui commented on a change in pull request #2116: [conf]
minorCompactionInterval should be greater than gcWaitTime
URL: https://github.com/apache/bookkeeper/pull/2116#discussion_r296997197
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -2646,6 +2646,9 @@ public void validate() throws ConfigurationException {
throw new ConfigurationException("For persisiting explicitLac,
journalFormatVersionToWrite should be >= 6"
+ "and FileInfoFormatVersionToWrite should be >= 1");
}
+ if (getMinorCompactionInterval() <= getGcWaitTime()) {
Review comment:
Related to
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java#L196,
i think it's better to allow "=" both `ServerConfiguration` and
`GarbageCollectorThread`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
