29x10 edited a comment on issue #2128: Issue #2127: Allow user override default SASL service name bookkeeper URL: https://github.com/apache/bookkeeper/pull/2128#issuecomment-514992616 @eolivelli 1. I agree with you to define it in SaslConstants. 2. Why I use system properties is because zookeeper use it too, "zookeeper.sasl.client.username". 3. Yes, it disallows you connect to different BK clusters if they use different service name in the name process. 4. Definitely I would update documentation page if you are fine with my changes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
