eolivelli commented on a change in pull request #2112: Issue #2106: Update
ZookKeeper dependency to 3.5.5
URL: https://github.com/apache/bookkeeper/pull/2112#discussion_r307977047
##########
File path: shaded/distributedlog-core-shaded/pom.xml
##########
@@ -82,8 +82,8 @@
<include>com.fasterxml.jackson.core:jackson-annotations</include>
<include>com.google.guava:guava</include>
<include>com.google.protobuf:protobuf-java</include>
- <!-- netty 3 (included from zookeeper) -->
- <include>io.netty:netty</include>
+ <!-- netty (included from zookeeper) -->
+ <include>io.netty:netty-all</include>
Review comment:
this is strage.
we did not shade netty 4 before, only netty 3, that is a different library
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
