reddycharan commented on a change in pull request #2166: Enhance
deferLedgerLockReleaseOfFailedLedger in ReplicationWorker
URL: https://github.com/apache/bookkeeper/pull/2166#discussion_r329165401
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestReplicationWorker.java
##########
@@ -502,10 +506,11 @@ public void
testBookiesNotAvailableScenarioForReplicationWorker() throws Excepti
@Override
public void run() {
try {
- Thread.sleep(4000);
+ Thread.sleep(3000);
isBookieRestarted.set(true);
+ Thread.sleep(500);
/*
- * after sleeping for 4000 msecs, restart one of the
+ * after sleeping for 3000 msecs, restart one of the
Review comment:
basically here we are starting Bookie after sometime (3 secs), till then the
ledger is expected to remain underreplicated. So we should be good with this
sleep, since we are not depending on this sleep for an event to happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services