reddycharan commented on a change in pull request #2173: Call exceptionHandler
if Bookie.start fails with exception.
URL: https://github.com/apache/bookkeeper/pull/2173#discussion_r333754571
##########
File path:
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/component/ComponentStarter.java
##########
@@ -72,6 +73,8 @@ public void run() {
// register a component exception handler
component.setExceptionHandler((t, e) -> {
+ log.error("Triggered exceptionHandler of Component: {} because of
Exception in Thread: {}",
Review comment:
yes, as we discussed it would be shared instance.
> multiple of them can fail at the same time, causing the hook to trigger
All we should care about is 'atleast-once' semantics. As long as
'shutdownHookThread' is executed once we should be fine. Anyhow in
`LifecycleComponentStack.start` Components are started sequentially, so
multiple of them failing at the same time is not going to happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
