karanmehta93 commented on a change in pull request #2182: Add API for Bookie
checksum verification writeFlags
URL: https://github.com/apache/bookkeeper/pull/2182#discussion_r336283795
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java
##########
@@ -30,12 +30,32 @@
public enum WriteFlag {
/**
- * Writes will be acknowledged after writing to the filesystem
+ * Bit 0 - Writes will be acknowledged after writing to the filesystem
* but not yet been persisted to disks.
*
* @see ForceableHandle#force()
*/
- DEFERRED_SYNC(0x1 << 0);
+ DEFERRED_SYNC(0x1 << 0),
+ /**
+ * Bits 1,2,3 - value 0.
Review comment:
1. That's a great point, will update it.
2. I am not sure what the benefit will be. Since this would require code
changes, someone may still mess it up. Currently, we don't throw exceptions in
`getWriteFlags()` method, silently ignoring unexpected values, otherwise I
could add up some tests that would have failed if someone tried to re-use them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
